Skip to content

Rehome ~150 tests/ui/issues/ tests to other subdirectories under tests/ui/ #143902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jul 13, 2025

Best reviewed commit-by-commit. I am pushing commits from my local branch as I am personally reviewing them for a first pass.

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

The URL addition at the end, as well as moving around the auxiliary files and editing the stderr files with the new filename, were done using a Python script.

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 13, 2025
@rust-log-analyzer

This comment has been minimized.

@Oneirical Oneirical force-pushed the uncountable-integer branch from 03a9549 to 2441737 Compare July 13, 2025 20:58
@Oneirical Oneirical changed the title Rehome tests/ui/issues/ tests to other subdirectories under tests/ui/ Rehome ~150 tests/ui/issues/ tests to other subdirectories under tests/ui/ Jul 13, 2025
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 13, 2025
@rust-log-analyzer

This comment has been minimized.

@Oneirical Oneirical force-pushed the uncountable-integer branch from 93e148e to 4c6ea67 Compare July 13, 2025 21:35
@rust-log-analyzer

This comment has been minimized.

@Oneirical Oneirical force-pushed the uncountable-integer branch from 4c6ea67 to 567002d Compare July 13, 2025 21:46
@rust-log-analyzer

This comment has been minimized.

@Oneirical Oneirical force-pushed the uncountable-integer branch from 567002d to 9b5900f Compare July 14, 2025 20:08
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@Oneirical Oneirical marked this pull request as ready for review July 15, 2025 02:53
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2025

There are changes to the tidy tool.

cc @jieyouxu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants