Skip to content

Add new user as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain. #143939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

he32
Copy link
Contributor

@he32 he32 commented Jul 14, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2025

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2025

⚠️ Warning ⚠️

  • There are username mentions (such as @user) in the commit messages of the following commits.
    Please remove the mentions to avoid spamming these users.

@he32 he32 changed the title Add @0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain. Add new user as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain. Jul 14, 2025
@jieyouxu
Copy link
Member

In your commit message, can you remove the direct @? Otherwise, they will keep getting pinged from any commits that reference their github handle, even in forks. You can r=me afterwards :)

@jieyouxu jieyouxu assigned jieyouxu and unassigned petrochenkov Jul 14, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jul 14, 2025

Thanks!
@bors delegate+ rollup

@bors
Copy link
Collaborator

bors commented Jul 14, 2025

✌️ @he32, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@he32
Copy link
Contributor Author

he32 commented Jul 14, 2025

I tried modifying the commit message. So based on hints above: @bors r=@jieyouxu

@bors
Copy link
Collaborator

bors commented Jul 14, 2025

📌 Commit 38f890d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jul 14, 2025

I tried modifying the commit message.

As in, the actual commit message of 38f890d that says

Add @0323pin as maintainer, and fix link to pkgsrc-wip and explain.

Since it's that mention which will ping them even in forks when the commit itself is referenced/used :D

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants