-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Add new Tier-3 target: riscv64a23-unknown-linux-gnu #145076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add new Tier-3 target: riscv64a23-unknown-linux-gnu #145076
Conversation
These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
This comment has been minimized.
This comment has been minimized.
f77bc29
to
577b85a
Compare
src/doc/rustc/src/platform-support/riscv64a23-unknown-linux-gnu.md
Outdated
Show resolved
Hide resolved
src/doc/rustc/src/platform-support/riscv64a23-unknown-linux-gnu.md
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tier 3 targets do not get built nor tested in rust-lang/rust CI, and by implication, no prebuilt artifacts will be distributed for Tier 3 targets.
src/doc/rustc/src/platform-support/riscv64a23-unknown-linux-gnu.md
Outdated
Show resolved
Hide resolved
src/doc/rustc/src/platform-support/riscv64a23-unknown-linux-gnu.md
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #145077) made this pull request unmergeable. Please resolve the merge conflicts. |
64b98ad
to
3ec3eea
Compare
This comment has been minimized.
This comment has been minimized.
3ec3eea
to
1be21d3
Compare
Some changes occurred in src/tools/clippy cc @rust-lang/clippy This PR modifies This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. This PR modifies If appropriate, please update |
1be21d3
to
87fd289
Compare
This will run all tests for `riscv64a23-unknown-linux-gnu` in a QEMU instance.
…u.md Co-authored-by: zachs18 <[email protected]>
This reverts commit 289688c.
Ready for review. @zachs18 @Noratrieb @jieyouxu |
Some minor issue here: the target requirement listed in ref: https://lf-rise.atlassian.net/wiki/spaces/HOME/pages/8587962/RVA23+Profile |
|
Pls review @jieyouxu @zachs18 @Noratrieb , i have make all changes requested. |
I don't support adding support for the Supm extension because of its nature. At least, support in This extension itself does not provide any instructions, CSRs or platform behavior constraints but only denotes existence of a platform-dependent facility to control pointer masking behavior. For instance, the Supm extension on Linux denotes EDIT: I don't support unless it's truly necessary (e.g. for interoperability with other object files compiled for RVA23U64). Even in this case, I would like to hear your thoughts about this extension. |
And I have a concern regarding adding (so much) supervisor-mode extensions despite being a Linux target (which normally means a user mode target). |
I personally recommend starting from RVA23U64 (excluding RVA23S64) and discuss possibilities extending it later. |
MCP: Tier 3 target proposal: riscv64a23-unknown-linux-gnu
Changes: