Skip to content

Reorder lto options from most to least optimizing #145533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smoelius
Copy link
Contributor

This is a follow up to rust-lang/cargo#15841.

@weihanglo pointed out the original order of the lto options in the Cargo book was consistent with https://doc.rust-lang.org/rustc/codegen-options/index.html?highlight=lto#lto.

The options in the Cargo book have since been reordered. This PR keeps the two references consistent.

@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2025
@lqd
Copy link
Member

lqd commented Aug 17, 2025

Thanks

r? lqd @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 17, 2025

📌 Commit cbfa17a has been approved by lqd

It is now in the queue for this repository.

@rustbot rustbot assigned lqd and unassigned lcnr Aug 17, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 17, 2025
Reorder `lto` options from most to least optimizing

This is a follow up to rust-lang/cargo#15841.

`@weihanglo` pointed out the original order of the `lto` options in the Cargo book was consistent with https://doc.rust-lang.org/rustc/codegen-options/index.html?highlight=lto#lto.

The options in the Cargo book have since been reordered. This PR keeps the two references consistent.
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 18, 2025
Reorder `lto` options from most to least optimizing

This is a follow up to rust-lang/cargo#15841.

``@weihanglo`` pointed out the original order of the `lto` options in the Cargo book was consistent with https://doc.rust-lang.org/rustc/codegen-options/index.html?highlight=lto#lto.

The options in the Cargo book have since been reordered. This PR keeps the two references consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants