Do not consider a T: !Sized
candidate to satisfy a T: !MetaSized
obligation.
#145537
+117
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example should fail to compile (and does under this PR, with the old and new solvers), but currently compiles successfully (playground), because (IIUC) the old solver's
lazily_elaborate_sizedness_candidate
/callers and the new solver'sTraitPredicate::fast_reject_assumption
/match_assumption
consider aT: _ Sized
candidate to satisfy aT: _ MetaSized
obligation, for either polarity_
, when that should only hold for positive polarity.Only observable with the internal-only
feature(negative_bounds)
, so might just be "wontfix".This example is added as a test in this PR (as well as testing that
foo<()>
andfoo<str>
are disallowed forfn foo<T: !MetaSized
).cc @davidtwco for
feature(sized_hierarchy)
Maybe similar to 91c53c9 from #143307