Skip to content

update mdbook #44267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

update mdbook #44267

wants to merge 2 commits into from

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 2, 2017

Fixes

warning: Package toml v0.4.5 does not have feature serde. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@RalfJung
Copy link
Member Author

RalfJung commented Sep 2, 2017

Ah dang, seems mdbook actually (re)moved some stuff. :/

I will leave this to someone who knows that code better, then.

@RalfJung RalfJung closed this Sep 2, 2017
@RalfJung RalfJung reopened this Sep 2, 2017
@RalfJung
Copy link
Member Author

RalfJung commented Sep 2, 2017

Actually this wasn't so hard. I removed the test code as there actually is no test subcommand registered with the clap::App.

@kennytm
Copy link
Member

kennytm commented Sep 2, 2017

linkchecker reports hundreds of broken links.

[01:14:55] grammar.html:399: broken link fragment `#number-literals` pointing to `reference/tokens.html`
[01:14:55] nomicon/print.html:464: broken link fragment `#dynamically-sized-types-dsts` pointing to `nomicon/exotic-sizes.html`
[01:14:55] nomicon/print.html:1181: broken link fragment `#example-aliasing-a-mutable-reference` pointing to `nomicon/lifetimes.html`
[01:14:55] nomicon/print.html:5444: broken link fragment `#foreign-calling-conventions` pointing to `nomicon/ffi.html`
[01:14:55] nomicon/repr-rust.html:101: broken link fragment `#dynamically-sized-types-dsts` pointing to `nomicon/exotic-sizes.html`
[01:14:55] nomicon/lifetime-mismatch.html:123: broken link fragment `#example-aliasing-a-mutable-reference` pointing to `nomicon/lifetimes.html`
...
[01:15:05] rustdoc/passes.html:94: broken link fragment `#--passes-add-more-rustdoc-passes` pointing to `rustdoc/command-line-arguments.html`
[01:15:05] rustdoc/passes.html:95: broken link fragment `#--no-defaults-dont-run-default-passes` pointing to `rustdoc/command-line-arguments.html`
[01:15:05] thread 'main' panicked at 'found some broken links', /checkout/src/tools/linkchecker/main.rs:49:8
[01:15:05] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:15:05] 
[01:15:05] 
[01:15:05] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:15:05] expected success, got: exit code: 101
[01:15:05] 
[01:15:05] 
[01:15:05] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:15:05] Build completed unsuccessfully in 0:31:30
[01:15:05] make: *** [check] Error 1
[01:15:05] Makefile:52: recipe for target 'check' failed

@alexcrichton
Copy link
Member

I think @steveklabnik was working on those regressions in mdbook (or at least knew of what was happening)

@RalfJung
Copy link
Member Author

RalfJung commented Sep 2, 2017

Yeah, seems like this is not just a smooth upgrade and "just" fixing the warning won't happen. Oh well.

@RalfJung RalfJung closed this Sep 2, 2017
@steveklabnik
Copy link
Member

Yes, I am working on this issue, sorry. We need https://github.com/azerupi/mdBook/pull/419 to land, and then I can cut an mdBook, and then we can do the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants