Promote references to constants instead of statics #67000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Dec 3, 2019
spastorino
force-pushed
the
remove-promoted-from-place
branch
4 times, most recently
from
a68a206 to
59d32ad
Compare
oli-obk
reviewed
Dec 4, 2019
spastorino
force-pushed
the
remove-promoted-from-place
branch
8 times, most recently
from
01ecd4a to
9eebc48
Compare
spastorino
force-pushed
the
remove-promoted-from-place
branch
from
9eebc48 to
1161a46
Compare
oli-obk
requested changes
Dec 10, 2019
spastorino
force-pushed
the
remove-promoted-from-place
branch
2 times, most recently
from
409de5b to
52d18bd
Compare
spastorino
changed the title
spastorino
force-pushed
the
remove-promoted-from-place
branch
from
52d18bd to
2ba78e2
Compare
spastorino
force-pushed
the
remove-promoted-from-place
branch
5 times, most recently
from
041233c to
8b262d2
Compare
This was referenced Jan 11, 2020
Merged
JohnTitor
added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Jan 11, 2020
This was referenced Jan 14, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 15, 2020
Add some regression tests Closes rust-lang#64848 (fixed by rust-lang#67631) Closes rust-lang#65918 (ICE is hidden by rust-lang#67000, no longer ICE) Closes rust-lang#66473 (fixed by rust-lang#68084) Closes rust-lang#67550 (set mir-opt-level to 3) r? @Centril
JohnTitor
added a commit
to JohnTitor/rustc-dev-guide
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Yuki Okushi <[email protected]>
JohnTitor
added a commit
to JohnTitor/rustc-dev-guide
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Yuki Okushi <[email protected]>
spastorino
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Mar 6, 2023
Signed-off-by: Yuki Okushi <[email protected]>
Merged
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 13, 2023
Update books ## rust-lang/nomicon 1 commits in 79b53665a7c61d171fb8c5ad0b73b371f9ee6ba7..1f3e4cd4fd88b5b5d45feb86a11b6d2f93e5a974 2023-03-12 21:51:29 UTC to 2023-03-12 21:51:29 UTC - Change incorrect reference to "above" in ffi.md (rust-lang/nomicon#404) ## rust-lang/reference 4 commits in a9afb04b47a84a6753e4dc657348c324c876102c..24c87f6663aed55b05d2cc286878f28f21918825 2023-03-11 13:53:24 UTC to 2023-02-28 16:07:20 UTC - Document movbe target feature (rust-lang/reference#1336) - fix typo (rust-lang/reference#1339) - fix: Typo/reference (rust-lang/reference#1338) - Document `cmpxchg16b` target feature (rust-lang/reference#1331) ## rust-lang/rustc-dev-guide 13 commits in b06dab8..b1b6d69 2023-03-13 02:42:00 UTC to 2023-03-03 11:12:51 UTC - Rename `config.toml.example` to `config.example.toml` (rust-lang/rustc-dev-guide#1641) - fix typo `SubstRef` to `SubstsRef` (rust-lang/rustc-dev-guide#1642) - tracing log along diff crates (rust-lang/rustc-dev-guide#1640) - Fix Rust Analyzer settings location (rust-lang/rustc-dev-guide#1637) - Reflect the changes in rust-lang#67000 (rust-lang/rustc-dev-guide#1632) - improve capacity note (rust-lang/rustc-dev-guide#1634) - Remove mention to lexer/parser refactoring (rust-lang/rustc-dev-guide#1629) - Update date reference about infer context variables (rust-lang/rustc-dev-guide#1630) - Update explnation about `Body.basic_blocks` (rust-lang/rustc-dev-guide#1631) - Add detail to contributing guide (rust-lang/rustc-dev-guide#1628) - Making the sentence more clear (rust-lang/rustc-dev-guide#1624) - Fixed typing error (rust-lang/rustc-dev-guide#1623) - update error code docs to reflect recent changes (rust-lang/rustc-dev-guide#1625)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
Codegen ZSTs without an allocation This makes sure that &[] is equivalent to unsafe code (from_raw_parts(dangling, 0)). No new stable guarantee is intended about whether or not we do this, this is just an optimization. This regressed in rust-lang#67000 (no comments I can see about that regression in the PR, though it did change the test modified here). We had previously performed this optimization since rust-lang#63635.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
Codegen ZSTs without an allocation This makes sure that &[] is equivalent to unsafe code (from_raw_parts(dangling, 0)). No new stable guarantee is intended about whether or not we do this, this is just an optimization. This regressed in rust-lang#67000 (no comments I can see about that regression in the PR, though it did change the test modified here). We had previously performed this optimization since rust-lang#63635.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
Codegen ZSTs without an allocation This makes sure that &[] is equivalent to unsafe code (from_raw_parts(dangling, 0)). No new stable guarantee is intended about whether or not we do this, this is just an optimization. This regressed in rust-lang#67000 (no comments I can see about that regression in the PR, though it did change the test modified here). We had previously performed this optimization since rust-lang#63635.
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Yuki Okushi <[email protected]>
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Yuki Okushi <[email protected]>
Kobzol
pushed a commit
to Kobzol/rustc-dev-guide
that referenced
this pull request
Jan 3, 2025
Signed-off-by: Yuki Okushi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk