Move more of `rustc::lint` into `rustc_lint` #68045

Centril · 2020-01-09T07:38:18Z

Based on #67806.

Here we try to consolidate more of the linting infra into rustc::lint. Some high-level notes:

We now store an Lrc<dyn Any + Send + Sync> as opposed to Lrc<LintStore> in the GlobalCtxt. This enables us to avoid referring to the type, breaking a cyclic dependency, and so we can move things from rustc::lint to rustc_lint.
in_derive_expansion is, and needs to, be moved as a method on Span.
We reduce the number of ways on tcx to emit a lint so that the developer UX is more streamlined.
LintLevelsBuilder is moved to rustc_lint::levels, leaving behind LintLevelMap/Set in a purified form due to current constraints (hopefully fixable in the future after Slimmer syntax #68133).
struct_lint_level is moved to rustc::lint due to current dependency constraints.
rustc::lint::context is moved to rustc_lint::context.
The visitors in rustc::lint are moved to rustc_lint::passes.

Also do some cleanup of the interface.

Centril · 2020-01-11T06:53:00Z

This is ready for review now.

Mark-Simulacrum

Changes look good.

It'd be helpful to include a description of the new/old crate deps in the PR description I think, but not critical (would help me understand exactly how things have moved at a high level).

src/librustc_lint/late.rs

src/librustc/lint/levels.rs

src/librustc/lint.rs

Centril · 2020-01-11T17:41:04Z

Added a PR description. :)

@bors r=Mark-Simulacrum

bors · 2020-01-11T17:41:05Z

📌 Commit 51078ce has been approved by Mark-Simulacrum

…lacrum Move more of `rustc::lint` into `rustc_lint` Based on rust-lang#67806. Here we try to consolidate more of the linting infra into `rustc::lint`. Some high-level notes: - We now store an `Lrc<dyn Any + Send + Sync>` as opposed to `Lrc<LintStore>` in the `GlobalCtxt`. This enables us to avoid referring to the type, breaking a cyclic dependency, and so we can move things from `rustc::lint` to `rustc_lint`. - `in_derive_expansion` is, and needs to, be moved as a method on `Span`. - We reduce the number of ways on `tcx` to emit a lint so that the developer UX is more streamlined. - `LintLevelsBuilder` is moved to `rustc_lint::levels`, leaving behind `LintLevelMap/Set` in a purified form due to current constraints (hopefully fixable in the future after rust-lang#68133). - `struct_lint_level` is moved to `rustc::lint` due to current dependency constraints. - `rustc::context` is moved to `rustc_lint::context`. - The visitors in `rustc::lint` are moved to `rustc_lint::passes`.

…lacrum Move more of `rustc::lint` into `rustc_lint` Based on rust-lang#67806. Here we try to consolidate more of the linting infra into `rustc::lint`. Some high-level notes: - We now store an `Lrc<dyn Any + Send + Sync>` as opposed to `Lrc<LintStore>` in the `GlobalCtxt`. This enables us to avoid referring to the type, breaking a cyclic dependency, and so we can move things from `rustc::lint` to `rustc_lint`. - `in_derive_expansion` is, and needs to, be moved as a method on `Span`. - We reduce the number of ways on `tcx` to emit a lint so that the developer UX is more streamlined. - `LintLevelsBuilder` is moved to `rustc_lint::levels`, leaving behind `LintLevelMap/Set` in a purified form due to current constraints (hopefully fixable in the future after rust-lang#68133). - `struct_lint_level` is moved to `rustc::lint` due to current dependency constraints. - `rustc::lint::context` is moved to `rustc_lint::context`. - The visitors in `rustc::lint` are moved to `rustc_lint::passes`.

@ghost

Rollup of 6 pull requests Successful merges: - #67494 (Constify more of alloc::Layout) - #67867 (Correctly check for opaque types in `assoc_ty_def`) - #67948 (Galloping search for binary_search_util) - #68045 (Move more of `rustc::lint` into `rustc_lint`) - #68089 (Unstabilize `Vec::remove_item`) - #68108 (Add suggestions when encountering chained comparisons) Failed merges: r? @ghost

src/librustc_lint/lib.rs

Rustup to rust-lang/rust#68045 This is blocked because `rustc_lint::context` is not pub module and `CheckLintNameResult` is not marked as `pub use`. changelog: none

rust-highfive assigned Mark-Simulacrum Jan 9, 2020

This comment has been minimized.

Sign in to view

Centril force-pushed the liberate-lints branch from 56e2c47 to 9e9b615 Compare January 9, 2020 09:51

Centril added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 9, 2020

This comment has been minimized.

Sign in to view

Centril force-pushed the liberate-lints branch 2 times, most recently from d288c66 to b980596 Compare January 10, 2020 06:13

This comment has been minimized.

Sign in to view

Centril force-pushed the liberate-lints branch 3 times, most recently from 9297562 to bc1c936 Compare January 11, 2020 06:41

Centril added 14 commits January 11, 2020 07:42

canonicalize some lint imports

3a2af32

move in_derive_expansion as Span method

b93addb

reduce diversity in linting methods

c151782

GlobalCtxt: Erase LintStore type.

6f1a79c

move logic to LintLevelsBuilder

03bdfe9

move LintSource to levels

f577b44

move struct_lint_level to levels.rs

eee84fe

inline maybe_lint_level_root

16bf278

lints: promote levels.rs to lint.rs & extract passes.rs

03dfa64

{rustc::lint -> rustc_lint}::internal

8c12c42

move rustc::lint::{context, passes} to rustc_lint.

f58db20

Also do some cleanup of the interface.

lints: move a comment

b592359

pacify the parallel compiler

8be2a04

fix ui-fulldeps & tests fallout

51078ce

Centril force-pushed the liberate-lints branch from bc1c936 to 51078ce Compare January 11, 2020 06:42

Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jan 11, 2020

Mark-Simulacrum reviewed Jan 11, 2020

View reviewed changes

src/librustc_lint/late.rs Show resolved Hide resolved

src/librustc/lint/levels.rs Outdated Show resolved Hide resolved

src/librustc/lint.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2020

Centril mentioned this pull request Jan 11, 2020

Rollup of 5 pull requests #68134

Closed

JohnTitor mentioned this pull request Jan 11, 2020

Rollup of 6 pull requests #68137

Closed

Centril mentioned this pull request Jan 12, 2020

Rollup of 6 pull requests #68142

Merged

bors merged commit 51078ce into rust-lang:master Jan 12, 2020

Centril deleted the liberate-lints branch January 12, 2020 05:42

JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Jan 12, 2020

Rustup to rust-lang/rust#68045

17e5517

JohnTitor reviewed Jan 12, 2020

View reviewed changes

src/librustc_lint/lib.rs Show resolved Hide resolved

cjgillot mentioned this pull request Jan 12, 2020

Move linting mechanisms to librustc_lint. #67737

Closed

JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Jan 13, 2020

Rustup to rust-lang/rust#68045

c97f7fc

JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Jan 13, 2020

Rustup to rust-lang/rust#68045

ce1c6b2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move more of `rustc::lint` into `rustc_lint` #68045

Move more of `rustc::lint` into `rustc_lint` #68045

Uh oh!

Centril commented Jan 9, 2020 •

edited by Mark-Simulacrum

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Centril commented Jan 11, 2020

Uh oh!

Mark-Simulacrum left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Centril commented Jan 11, 2020

Uh oh!

bors commented Jan 11, 2020

Uh oh!

Uh oh!

Uh oh!

Move more of rustc::lint into rustc_lint #68045

Move more of rustc::lint into rustc_lint #68045

Uh oh!

Conversation

Centril commented Jan 9, 2020 • edited by Mark-Simulacrum Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Centril commented Jan 11, 2020

Uh oh!

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Centril commented Jan 11, 2020

Uh oh!

bors commented Jan 11, 2020

Uh oh!

Uh oh!

Uh oh!

Move more of `rustc::lint` into `rustc_lint` #68045

Move more of `rustc::lint` into `rustc_lint` #68045

Centril commented Jan 9, 2020 •

edited by Mark-Simulacrum

Loading