-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Beta] Backport ICE fix in Clippy #85740
Conversation
Fix stack overflow issue in `redundant_pattern_matching` Fixes rust-lang#7169 ~~cc `@Jarcho` Since tomorrow is release day and we need to get this also fixed in beta, I'll just revert the PR instead of looking into the root issue. Your changes are good, so if you have an idea what could cause this stack overflow and know how to fix it, please open a PR that reverts this revert with a fix.~~ r? `@llogiq` changelog: none (fixes stack overflow, but this was introduced in this release cycle)
Backport of rust-lang#7170 to beta r? `@ghost` changelog: none (fixes stack overflow, but this was introduced in this release cycle) Now actually opened towards the `beta` branch.
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
@bors r+ rollup=never |
📌 Commit 47e2265 has been approved by |
⌛ Testing commit 47e2265 with merge cc3d5735be31a3dbc613ecee1c765d841104cfd4... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Seems spurious? |
@bors retry let's see! |
⌛ Testing commit 47e2265 with merge 83382195548d85871db2e9f68d253d47a514b4e5... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
This error seems to come from building LLVM. I don't think this PR can have anything to do with that? |
@bors retry Let's hope it is spurious, seems to not be affecting other PRs at least. |
⌛ Testing commit 47e2265 with merge b1a2a3f085a666aedbf723fd30648eca2caf4dd7... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Oh no. I would assume that this error has something to do with this PR targeting the beta branch. The last successful merge into beta was #85588 12 days ago.
This suggests incompatibility between the installed MSVC toolchain and the clang compiler version. |
Looks like this error occurred on all recent beta merges :( |
⌛ Testing commit 47e2265 with merge da552a9510e52720e6e251d0bf0229eb97d1b06f... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
CI issue has been fixed, @bors retry |
☀️ Test successful - checks-actions |
This backports an ICE / stack overflow fix from rust-lang/rust-clippy#7170.
cc rust-lang/rust-clippy#7169
cc @llogiq @camsteffen
r? @Mark-Simulacrum