Skip to content

Adds 'with' to the bootstrapping docs to help clarify how to build a new compiler #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025

Conversation

martinomburajr
Copy link
Contributor

The sentence

However it was abandoned long ago and the only way to build a modern version of rustc is a slightly less modern version.

feels like it's grammatically missing the preposition 'with', as well as some commas around "However" etc.

@tshepang
Copy link
Member

tshepang commented May 1, 2025

this is a good change, and it exposes text that is almost exactly duplicated... are you happy to remove/reduce that, or would you rather that happen in a different pr

@tshepang tshepang merged commit 4d2e6a9 into rust-lang:master May 1, 2025
1 check passed
@tshepang
Copy link
Member

tshepang commented May 1, 2025

will defer that to a future pr... no need to delay this

@martinomburajr
Copy link
Contributor Author

@tshepang thanks for the review 🙏 . I had noticed the paragraph is duplicated word for word across both files. I had thought about removing the second occurrence, but wasn't sure if this was intended.

If we were to go forward with this, the two options that make sense to me are:

  1. Summarize what was in src/building/bootstrapping/intro.md into src/building/bootstrapping/what-bootstrapping-does.md
  2. Completely remove the duplicate paragraph in what-bootstrapping-does.md

Let me know what makes sense and I can make the quick change.

@tshepang
Copy link
Member

tshepang commented May 2, 2025

or 2a, add a link to that bit of text
I am curious what a summary would look like though... the text is short already
feel free to decide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants