remove "Easy" and "good-first-issue" from help-wanted-search #2409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, they gavea a warning about being "invalid filters". that seems like a github bug, because they were definitely present in the clippy and reference repos, but i worked around it by asking clippy and the reference to change to `E-easy` and `good first issue` instead. update the search now, so that people don't see a warning.
|
the warnings: |
|
why I search with the new link will get these warnings: 
emm, github bug? |
|
The new link looks good to me. |
|
Somehow I get a different result than both of you:
|
|
I agree that something fishy is going on here (probably github's search Javascript is picking a random repository to determine which labels exist), but can we agree that this PR is a strict improvement over the status quo? |
|
(#2413 also updated it to account for glacier) (I can't push to ur branch so) |
jieyouxu
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, they gave a warning about being "invalid filters". that seems like a github bug, because they were definitely present in the clippy and reference repos, but i worked around it by asking clippy and the reference to change to
E-easyandgood first issueinstead. update the search now, so that people don't see a warning.