Skip to content

remove "Easy" and "good-first-issue" from help-wanted-search #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 23, 2025

previously, they gave a warning about being "invalid filters". that seems like a github bug, because they were definitely present in the clippy and reference repos, but i worked around it by asking clippy and the reference to change to E-easy and good first issue instead. update the search now, so that people don't see a warning.

previously, they gavea a warning about being "invalid filters". that
seems like a github bug, because they were definitely present in the
clippy and reference repos, but i worked around it by asking clippy and
the reference to change to `E-easy` and `good first issue` instead.
update the search now, so that people don't see a warning.
@jyn514
Copy link
Member Author

jyn514 commented May 23, 2025

the warnings: image

@chenyukang
Copy link
Member

why I search with the new link will get these warnings:

image

emm, github bug?

@dianqk
Copy link
Member

dianqk commented May 24, 2025

The new link looks good to me.
image

@jieyouxu
Copy link
Member

Somehow I get a different result than both of you:

Screenshot 2025-05-27 022857

@jyn514
Copy link
Member Author

jyn514 commented May 26, 2025

I agree that something fishy is going on here (probably github's search Javascript is picking a random repository to determine which labels exist), but can we agree that this PR is a strict improvement over the status quo?

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks

@jieyouxu
Copy link
Member

jieyouxu commented May 27, 2025

(#2413 also updated it to account for glacier)

(I can't push to ur branch so)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants