build: allow windows-sys 0.59
#545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ErichDonGubler
force-pushed
the
windows-sys-0.59
branch
2 times, most recently
from
183239c to
2068160
Compare
ErichDonGubler
force-pushed
the
windows-sys-0.59
branch
from
2068160 to
cdd3f30
Compare
3 tasks
|
This doesn't work due to #526. We need to update public methods to take void pointers so that windows-sys types are not in the public API. |
|
Closing this in favour of a straight update to v0.59, which means a lot less code changes: #579. |
|
@Thomasdezeeuw: There are no more substantive changes here than in that PR, if you examine the final commit. Most changes here were a broad appeal to The advantage of using a range dependency is that users' migration path becomes significantly easier. Are you sure that a straight upgrade is actually meaningfully easier for maintenance here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.