Add tcp retries to windows #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasdezeeuw
requested changes
Feb 24, 2025
Cargo.toml
Outdated
| @@ -54,7 +55,7 @@ features = ["all"] | |||
| libc = "0.2.150" | |||
|
|
|||
| [target.'cfg(windows)'.dependencies.windows-sys] | |||
| version = "0.52" | |||
| version = "0.59" | |||
There was a problem hiding this comment.
This is a breaking change, can't accept that at the moment, see #526
There was a problem hiding this comment.
Do you need a volunteer to implement #526 (comment)? I'm happy to take a stab at it, or pass the feedback to someone internally at MSFT
There was a problem hiding this comment.
windows-sys was updated to 0.59 in #579.
Thomasdezeeuw
force-pushed
the
add-tcp-retries-to-windows
branch
from
3b6ea10 to
1ea4091
Compare
Thomasdezeeuw
approved these changes
May 25, 2025
Thomasdezeeuw
force-pushed
the
add-tcp-retries-to-windows
branch
from
1ea4091 to
07f0700
Compare
|
Thanks @keithmattix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump windows sys and add support for retries on Windows