Do not use windows-sys types in public API #576
Merged
+139
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
force-pushed
the
windows-void-ptrs
branch
from
7c4d05f to
d0fae1e
Compare
Darksonn
force-pushed
the
windows-void-ptrs
branch
from
d0fae1e to
17bba44
Compare
Darksonn
force-pushed
the
windows-void-ptrs
branch
2 times, most recently
from
ef9479c to
390b68d
Compare
Darksonn
force-pushed
the
windows-void-ptrs
branch
from
390b68d to
abcb2a5
Compare
Darksonn
changed the title
Darksonn
force-pushed
the
windows-void-ptrs
branch
4 times, most recently
from
5d12687 to
d10f87e
Compare
Darksonn
force-pushed
the
windows-void-ptrs
branch
from
d10f87e to
1b381e8
Compare
Thomasdezeeuw
approved these changes
May 24, 2025
|
|
||
| impl SockAddrStorage { | ||
| /// Construct a new storage containing all zeros. | ||
| #[inline] |
There was a problem hiding this comment.
Do we need these #[inline]s?
| rust: | ||
| # `check-external-types` requires a specific Rust nightly version. See | ||
| # the README for details: https://github.com/awslabs/cargo-check-external-types | ||
| - nightly-2024-06-30 |
There was a problem hiding this comment.
The readme mentions nightly-2025-05-04 here: https://github.com/awslabs/cargo-check-external-types?tab=readme-ov-file#how-to-use. But I assume this version will also work.
There was a problem hiding this comment.
It seems like the releases page has the recent version: https://github.com/awslabs/cargo-check-external-types/releases.
| matrix: | ||
| os: | ||
| - windows-latest | ||
| - ubuntu-latest |
There was a problem hiding this comment.
Do we need to run it on different OS? Can we do cross-OS checking?
There was a problem hiding this comment.
Cross-OS checking doesn't seem to work (well), -Zbuild-std can't be passed.
|
Merging this now. @Darksonn we can resolve the question I have later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #526