Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework SIMD zeroing #1682

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Rework SIMD zeroing #1682

merged 1 commit into from
Nov 30, 2024

Conversation

TDecking
Copy link
Contributor

This PR adds a dedicated ZERO constant for the internal SIMD types and uses it intead of current idioms such as splat(0) or setzero_pd().as_<type>(). The result is improved code generation in non-optimized builds as well as a small line count reduction.

@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Amanieu
Copy link
Member

Amanieu commented Nov 29, 2024

CI should be fixed now, can you rebase?

@Amanieu Amanieu enabled auto-merge November 29, 2024 23:43
@Amanieu Amanieu added this pull request to the merge queue Nov 30, 2024
Merged via the queue into rust-lang:master with commit 1bbe5d7 Nov 30, 2024
54 checks passed
@TDecking TDecking deleted the zero branch November 30, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants