Fix build and CLI behaviour for stdarch-gen-arm. #1705
+134
−3,305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure stdarch-gen-arm to use `Group`s with `Delimiter`s rather
than ad-hoc `Punct`s.
`Punct` should only be used to represent specific characters, and never
for bracket-like characters. Recent versions of `Punct::new` check this
with an assertion.
Note that there doesn't appear to be a way to emit a line break for
formatting reasons — `Punct::new('\n', ...)` no longer works — so this
also removes all blank lines between functions in the generated files.
Fix both the instructions for how to regenerate each `generated.rs`, and the logic for inferring the correct output path from each input `.spec.yml`.
|
Someone commented that I'd forgotten to regenerate the files. For some reason, I can't see the comment on GitHub, but they were right; the instructions at the top of each |
jacobbramley
force-pushed
the
dev/punct
branch
from
ecaa3ea to
1a6b9f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
stdarch-gen-armbuild by correcting misuse ofproc_macro2::Punct. Our usage was always incorrect, but recent versions ofPunct::newinclude assertions that show it.Also fix the
generated.rspath inference.