Skip to content

Add rustdoc team to rust-forge and triagebot maintenance #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

Add rustdoc team to rust-forge and triagebot maintenance #1831

merged 1 commit into from
May 26, 2025

Conversation

GuillaumeGomez
Copy link
Member

Suggested by @ehuss in rust-lang/rust-forge#852 (comment).

Hopefully I correctly understood what they meant.

r? @ehuss

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

Dry-run check results 

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/rust-forge':
      Permission Changes:
        Giving team 'rustdoc' maintain permission

ehuss
ehuss reviewed May 21, 2025
View reviewed changes
repos/rust-lang/triagebot.toml Outdated
@@ -7,6 +7,7 @@ bots = ["rustbot"]
[access.teams]
infra = "maintain"
triagebot = "maintain"
rustdoc = "maintain"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think there was some confusion. I meant add the new rustdoc directory to https://github.com/rust-lang/rust-forge/blob/648ca186b757f85e556d52a672b10af86c02110e/triagebot.toml#L20 with the appropriate reviewers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense haha

@GuillaumeGomez
Copy link
Member Author

Made the changes both here and in rust-forge.

@jackh726 jackh726 added this pull request to the merge queue May 26, 2025
Merged via the queue into rust-lang:master with commit a76e62d May 26, 2025
3 checks passed
@GuillaumeGomez GuillaumeGomez deleted the forge-rustdoc branch May 27, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

@fmease fmease fmease approved these changes

@aDotInTheVoid aDotInTheVoid aDotInTheVoid approved these changes

@jackh726 jackh726 jackh726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @ehuss @fmease @aDotInTheVoid @jackh726