Check if connection is valid while get client from poll #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
…tion Signed-off-by: xizheyin <[email protected]>
xizheyin
force-pushed
the
check-db-client
branch
from
29d8c19 to
4724894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May Fixes #1887
It is possible that the client connections in the pool have not been used for a long time, and the server side automatically closes the connection with the client, however, is_closed only checks the status of the local client and not whether the server side has a connection. I added the check to ensure the robustness.
Alternatively, there are other ways to ensure a more continuous connection.