Update par_azip!() syntax to match azip!()
#722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the apply method a parameter (so that par_azip can reuse azip, in the next commit).
bluss
force-pushed
the
update-par-azip
branch
from
1ddaba2 to
10301a4
Compare
bluss
commented
Sep 20, 2019
| }; | ||
| // Build Finish Rule (both) | ||
| (@finish ($z:expr) [$($aa:expr,)*] [$($p:pat,)+] in { $($t:tt)*}) => { | ||
| use $crate::parallel::prelude::*; |
There was a problem hiding this comment.
Didn't notice it before, but par_apply is an inherent method nowadays and no trait use is needed.
We simplify the duplication in par_azip a lot, since we can now just reuse `azip`'s internal rule and pass it the name of the finisher method, which is `par_apply`.
bluss
force-pushed
the
update-par-azip
branch
from
10301a4 to
0c1a3d7
Compare
jturner314
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the syntax to match. First refactor
azip!()slightly, so that we can reuse it wholesale frompar_azip.cc #670
cc #721