Copy netlink-packet-utils code to netlink-packet-core #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinqon
force-pushed
the
move-utils-code-to-core
branch
from
b2f7247 to
90b0556
Compare
qinqon
changed the title
Signed-off-by: Enrique Llorente <[email protected]>
qinqon
force-pushed
the
move-utils-code-to-core
branch
from
90b0556 to
7f142c4
Compare
qinqon
changed the title
cathay4t
requested changes
Jun 16, 2025
src/lib.rs
Outdated
Comment on lines
271
to
275
| pub mod nla; | ||
| pub use self::nla::*; | ||
|
|
||
| pub mod parsers; | ||
| pub use self::parsers::*; |
There was a problem hiding this comment.
Since we are breaking stuff, let's not expose the module path to public allowing us to re-organize the code in the future. Try expose everything as top level data type or function and don't use ::*.
pub use self::nla::{NlaBuffer, DefaultNla, NlaIterator};
pub use self::parsers::{parse_u8, ...};
| } | ||
|
|
||
| #[macro_export(local_inner_macros)] | ||
| macro_rules! buffer { |
There was a problem hiding this comment.
Rust document said we should not use local_inner_macros.
We actually only use this buffer! macro in other crates.
There was a problem hiding this comment.
So I should just use "cratre" right ?
UPDATE: Ahh ok just leave #[macro_export]
Cargo.toml
Outdated
| @@ -14,7 +14,6 @@ description = "netlink packet types" | |||
| [dependencies] | |||
| anyhow = "1.0.31" | |||
There was a problem hiding this comment.
This crate is not required anymore.
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
qinqon
force-pushed
the
move-utils-code-to-core
branch
from
7f142c4 to
e3b38a9
Compare
Signed-off-by: Enrique Llorente <[email protected]>
qinqon
force-pushed
the
move-utils-code-to-core
branch
from
e3b38a9 to
fa25183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the functionalit at netlink-packet-util to this repository so we can deprecate that repo making dependencies easier to handle.