generated from rust-vmm/crate-template
-
Notifications
You must be signed in to change notification settings - Fork 57
Added snapshot feature for vhost-device-vsock. #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
WeiChungHsu
wants to merge
5
commits into
rust-vmm:main
Choose a base branch
from
WeiChungHsu:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0335b8a
Added snapshot feature for vhost-device-vsock.
WeiChungHsu 96fd679
Added snapshot feature for vhost-device-vsock.
WeiChungHsu 7f16bea
Merge branch 'main' into main
WeiChungHsu f76c724
Merge branch 'rust-vmm:main' into main
WeiChungHsu 8adcb79
Update the Cargo file to point to my another change in vring functions.
WeiChungHsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this whole abstraction is needed, because if a thread is created, then
Option<JoinHandle<()>>
is notNone
. Plus,created
field does not guard againsthandle
beingNone
because even if they are guarded under the same mutex, they are accessed separately (!). Change thehandler_thread
field toMutex<Option<JoinHandle<()>>>
and incheck_device_state
function you can lock the mutex and useOption::take
to move the thread handle and join it if it's notNone
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just fixed the codes based on the suggestion. Please let me know if it meets your expectation.