Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): files needs to migrated from Tape to Jest #8

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruzell22
Copy link
Owner

@ruzell22 ruzell22 commented Jan 28, 2025

Commit to be reviewed


fix(logger): files needs to migrated from Tape to Jest

Primary Changes
---------------
1. Fixed logger.test.ts after removing the skip on the test and UUID marker
now appears in the custom stream output
2. Migrated test file from tape to jest test
3. Removed file path of logger.test.ts in testPathIgnorePatterns to run jest
test

Fixes:

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@ruzell22 ruzell22 changed the title fix(logger): Files needs to migrated from Tape to Jest fix(logger): files needs to migrated from Tape to Jest Jan 28, 2025
@ruzell22 ruzell22 force-pushed the issue1465draft branch 2 times, most recently from 42a9bcb to 2214e3f Compare February 3, 2025 03:51
Primary Changes
---------------
1. Fixed logger.test.ts after removing the skip on the test and UUID marker
now appears in the custom stream output
2. Migrated test file from tape to jest test
3. Removed file path of logger.test.ts in testPathIgnorePatterns to run jest
test

Fixes:

Signed-off-by: ruzell22 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant