Added support for multiple messages files #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n means that file order matters if the same key exists in multiple files
rxaviers
reviewed
Jan 12, 2018
| return null; | ||
| readMessages: (messagesFilepaths, locale) => { | ||
| let messages = {}; | ||
| const filepaths = [].concat(messagesFilepaths); |
There was a problem hiding this comment.
Great solution to make it always an array.
|
Please, can you add a test? |
|
@rxaviers I have added unit tests, however when "es" is included in the supported locales , there is a module parse failure. I'm having some trouble locating the root of this problem. |
rxaviers
reviewed
Jan 17, 2018
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "en": { | |||
|
Fixed |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11
Note that the Object.assign means that file order matters if the same key exists in multiple files.
I can add unit tests as needed, but I figured I would at least get eyes on this.