chore: clippy updates

Cargo.toml

@@ -88,6 +88,10 @@ otsu_level = ["image"]
 #/// Adds "client" features do decode many common data formats found in barcodes
 client_support = []
 
+#/// For the `FilteredImageReader` if this feature is enabled it
+#/// will always reverse the order of pyramid scans
+reverse_pyramid_layers = []
+
 [workspace]
 members = [
     "crates/one-d-proc-derive",

src/datamatrix/data_matrix_reader.rs

@@ -91,7 +91,7 @@ impl Reader for DataMatrixReader {
                     let decoded = DECODER.decode(symbol.getBits());
                     if decoded.is_ok() {
                         points = symbol.getPoints().to_vec();
-                        return Ok(decoded?);
+                        return decoded;
                     } else {
                         continue;
                     }

src/datamatrix/detector/zxing_cpp_detector/cpp_new_detector.rs

@@ -15,7 +15,7 @@ use std::{cell::RefCell, rc::Rc};
 
 use crate::{
     common::{
-        cpp_essentials::RegressionLineTrait, BitMatrix, DefaultGridSampler, DetectorRXingResult,
+        cpp_essentials::RegressionLineTrait, BitMatrix, DefaultGridSampler,
         GridSampler, Quadrilateral, Result,
     },
     datamatrix::detector::{

src/datamatrix/encoder/minimal_encoder.rs

@@ -812,6 +812,7 @@ impl Edge {
      *  - Mode is EDIFACT and characterLength is less than 4 or the remaining characters can be encoded in at most 2
      *    ASCII bytes.
      *  - Mode is C40, TEXT or X12 and the remaining characters can be encoded in at most 1 ASCII byte.
+     * 
      *  Returns mode in all other cases.
      * */
     pub fn getEndMode(&self) -> Result<Mode> {

src/filtered_image_reader.rs

@@ -90,7 +90,7 @@ impl LumImagePyramid {
             new_self.add_layer_with_factor(factor).ok()?;
         }
 
-        #[cfg(reverse_pyramid_layers)]
+        #[cfg(feature = "reverse_pyramid_layers")]
         // Reversing the layers means we'd start with the smallest. that can make sense if we are only looking for a
         // single symbol. If we start with the higher resolution, we get better (high res) position information.
         // TODO: see if masking out higher res layers based on found symbols in lower res helps overall performance.

tests/github_issues.rs

@@ -488,8 +488,7 @@ fn issue_51_multiple_detection() {
     use image::DynamicImage;
     use rxing::{
         common::HybridBinarizer,
-        multi::{GenericMultipleBarcodeReader, MultipleBarcodeReader},
-        BarcodeFormat, BinaryBitmap, BufferedImageLuminanceSource, DecodeHintType, DecodeHintValue,
+        multi::{GenericMultipleBarcodeReader, MultipleBarcodeReader}, BinaryBitmap, BufferedImageLuminanceSource, DecodeHintType, DecodeHintValue,
         DecodingHintDictionary, Exceptions, MultiUseMultiFormatReader,
     };