Skip to content

Commit

Permalink
Merge pull request #256 from s-xix98/251-playwrightのバージョン確認してciキャッシュする
Browse files Browse the repository at this point in the history
不要になったコメント削除
  • Loading branch information
wyoheiii authored May 30, 2023
2 parents 261cb31 + f4340e1 commit d9cfac0
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/storybook-test.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
# storybook test

# cache-playwright の key が `frontend/package-lock.json` になっているが
# playwright の version とかで 見た方がいいかもだが、
# 現状 プルリクごとに playwright の install が走るので とりあえずこれで 問題なしとする。
# 下記記事だと `package-lock.json` の 依存バージョン を 拾ってきているが この辺でもいいのか?
# - https://playwrightsolutions.com/playwright-github-action-to-cache-the-browser-binaries/
#
# ref
# - https://github.com/microsoft/playwright-github-action
# - `~/.cache/ms-playwright`
Expand Down

0 comments on commit d9cfac0

Please sign in to comment.