Dockerfile: allow specifying s3gw directory #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requiring the copy of the `entrypoint.sh` script, we did not account for actions on other repositories relying on checking out the `s3gw.git` repository and building images using the Dockerfile from within an `s3gw` directory. This causes the script to not be found, because it's instead in `s3gw/tools/entrypoint.sh`, versus what we expected, `tools/entrypoint.sh`. This helps addressing that by allowing the caller to specify on which directory we can find the s3gw repository. Signed-off-by: Joao Eduardo Luis <[email protected]>
jecluis
force-pushed
the
wip-fix-dockerfile
branch
from
ef0a29c to
5a11d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requiring the copy of the
entrypoint.shscript, we did not account for actions on other repositories relying on checking out thes3gw.gitrepository and building images using the Dockerfile from within ans3gwdirectory. This causes the script to not be found, because it's instead ins3gw/tools/entrypoint.sh, versus what we expected,tools/entrypoint.sh.This helps addressing that by allowing the caller to specify on which directory we can find the s3gw repository.
Signed-off-by: Joao Eduardo Luis [email protected]