Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow #813

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Fix release workflow #813

merged 2 commits into from
Nov 20, 2023

Conversation

m-ildefons
Copy link
Contributor

Describe your changes

Drop docker buildx from the release workflow. The builds using buildx had various issues with timeouts and TLS errors.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

@m-ildefons m-ildefons added kind/bug Something isn't working area/CI Continuous Integration labels Nov 20, 2023
@m-ildefons m-ildefons added this to the v0.23.0 milestone Nov 20, 2023
@m-ildefons m-ildefons requested a review from jecluis November 20, 2023 12:12
@m-ildefons m-ildefons self-assigned this Nov 20, 2023
@m-ildefons
Copy link
Contributor Author

The release workflow is expected to fail on this step since there are no release notes matching the dummy release tag provided. However, the build of the container succeeded, which is the important part.

jecluis
jecluis previously approved these changes Nov 20, 2023
Copy link
Contributor

@jecluis jecluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

jecluis
jecluis previously approved these changes Nov 20, 2023
Drop buildx from release and nightly workflows.
Buildx was having odd trouble with networking related errors.

Signed-off-by: Moritz Röhrich <[email protected]>
@m-ildefons m-ildefons force-pushed the debug/release-workflow branch from 432092c to b28b448 Compare November 20, 2023 14:22
Signed-off-by: Moritz Röhrich <[email protected]>
@m-ildefons m-ildefons merged commit 7aa1a64 into main Nov 20, 2023
@m-ildefons m-ildefons deleted the debug/release-workflow branch November 20, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants