Dockerfile: Turn on ENABLE_GIT_VERSION #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENABLE_GIT_VERSION works fine when ceph is checked out normally,
but not when it's a submodule of s3gw that's copied into the Docker
build environment (".git" is a file that refers to a parent directory
that doesn't exist in this case). Happily, we can cheat by mounting
the s3gw directory into the buildenv, then we can run a couple of git
commands inside *there* to extract the commit hash and version tags
ceph needs then save them to /srv/ceph/src/.git_version where they'll
be picked up by the ceph build.
Fixes: https://github.com/aquarist-labs/s3gw/issues/431
Signed-off-by: Tim Serong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENABLE_GIT_VERSION works fine when ceph is checked out normally, but not when it's a submodule of s3gw that's copied into the Docker build environment (".git" is a file that refers to a parent directory that doesn't exist in this case). Happily, we can cheat by mounting the s3gw directory into the buildenv, then we can run a couple of git commands inside there to extract the commit hash and version tags ceph needs then save them to /srv/ceph/src/.git_version where they'll be picked up by the ceph build.
Fixes: https://github.com/aquarist-labs/s3gw/issues/431
Checklist before requesting a review