Skip to content

Commit

Permalink
Feature/fix nulls singer decimal (#9)
Browse files Browse the repository at this point in the history
* Bumping Version

Handling NULL's / None Columns with Singer.Decimal

* Bumping Version

Handling NULL's / None Columns with Singer.Decimal

* Handling NULL's/None in Columns with Singer.Decimal
  • Loading branch information
s7clarke10 authored Oct 3, 2022
1 parent a41d7f0 commit d30b180
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 1.0.6
* Handling NULL's / None in Singer.Decimal columns.

## 1.0.5
* Change sort order by col id
* Resolving missing Primary Key index
Expand All @@ -23,4 +26,4 @@
* Raise Error if LOG_BASED replication method is used. Log based is not available under Sybase.

## 1.0.0
* Original Release supporting extracts from Sybase ASE / Sybase 16.
* Original Release supporting extracts from Sybase ASE / Sybase 16.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

setup(
name="tap-sybase",
version="1.0.5",
version="1.0.6",
description="Singer.io tap for extracting data from SQL Server - PipelineWise compatible",
author="Stitch",
url="https://github.com/s7clarke10/tap-sybase",
Expand Down
5 changes: 4 additions & 1 deletion tap_sybase/sync_strategies/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ def row_to_singer_record(catalog_entry, version, row, columns, time_extracted):
elif isinstance(elem, uuid.UUID):
row_to_persist += (str(elem),)
elif property_format == 'singer.decimal':
row_to_persist += (str(elem),)
if elem is None:
row_to_persist += (elem,)
else:
row_to_persist += (str(elem),)
else:
row_to_persist += (elem,)
rec = dict(zip(columns, row_to_persist))
Expand Down

0 comments on commit d30b180

Please sign in to comment.