Task 1. #84
Open
Task 1. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadads1337
requested changes
May 24, 2021
src/Voitov/Task1/CMakeLists.txt
Outdated
|
|
||
| find_package(Qt5 COMPONENTS Widgets REQUIRED) | ||
|
|
||
| add_executable(EXE ${SRC}) |
There was a problem hiding this comment.
Давайте дадим осмысленное название исполняемому файлу EXE -> VoitovTask1
src/Voitov/Task1/figure.hpp
Outdated
|
|
||
| void setColor(QVector3D rgb); | ||
|
|
||
| QVector4D getColor(); |
There was a problem hiding this comment.
Suggested change
| QVector4D getColor(); | |
| [[nodiscard]] QVector4D getColor() const noexcept; |
и ниже
src/Voitov/Task1/figure.hpp
Outdated
|
|
||
| void setColor(QVector3D rgb); | ||
|
|
||
| QVector4D getColor(); |
There was a problem hiding this comment.
Suggested change
| QVector4D getColor(); | |
| [[nodiscard]] QVector4D getColor() const noexcept; |
и ниже
| class figure | ||
| { | ||
| public: | ||
| virtual ~figure() = default; |
There was a problem hiding this comment.
Зачем виртуальный деструктор?
src/Voitov/Task1/figure.cpp
Outdated
| return this->gIndexes; | ||
| } | ||
|
|
||
| void geometry::figure::setColor(QVector3D rgb){ |
There was a problem hiding this comment.
Suggested change
| void geometry::figure::setColor(QVector3D rgb){ | |
| void geometry::figure::setColor(const QVector3D rgb){ |
src/Voitov/Task1/figure.cpp
Outdated
| #include "figure.hpp" | ||
|
|
||
| namespace geometry{ | ||
| //figure::figure(){} |
src/Voitov/Task1/cube.hpp
Outdated
|
|
||
| namespace geometry{ | ||
|
|
||
| class Cube final: public figure { |
There was a problem hiding this comment.
Само наличие структуры cube бесмысленно. Либо делайте figure интерфейсом, либо мержите оба этих класса
added 3 commits
May 26, 2021 14:13
изменено: src/Voitov/Task1/CMakeLists.txt изменено: src/Voitov/Task1/cube.hpp удалено: src/Voitov/Task1/figure.cpp изменено: src/Voitov/Task1/figure.hpp новый файл: src/Voitov/Task1/figureinformation.cpp новый файл: src/Voitov/Task1/figureinformation.h изменено: src/Voitov/Task1/main.cpp изменено: src/Voitov/Task1/uiwindow.cpp изменено: src/Voitov/Task1/uiwindow.h изменен исполняемый файл EXE -> VoitovTask1 Добавлены [[nodiscard]] и const noexcept в нужных методах Удален лишний код класс figure переделан в интерфейс, а также добавлен базовый класс FigureInformation
Nvoid09
force-pushed
the
feature-voitov-task-1
branch
from
3bb138c to
acdbcea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: Key c - change cube color, Key B - change background color