Task 2. #86
Open
Task 2. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadads1337
requested changes
May 24, 2021
src/Voitov/Task2/CMakeLists.txt
Outdated
|
|
||
| find_package(Qt5 COMPONENTS Widgets REQUIRED) | ||
|
|
||
| add_executable(EXE ${SRC}) |
There was a problem hiding this comment.
Название исполняемого файла нужно поправить
src/Voitov/Task2/cube.cpp
Outdated
| auto position = QVector3D{0, 0, 0}; | ||
| auto normal = QVector3D{0, 0, 0}; | ||
|
|
||
| normal[coord] = int(side / 3 * 2) - 1; |
There was a problem hiding this comment.
c cast нужно заменить на static_cast
src/Voitov/Task2/uiwindow.h
Outdated
| GLint posAttr_ = 0; | ||
| GLint matrixUniform_ = 0; | ||
|
|
||
| geometry::figure* figures; |
src/Voitov/Task2/uiwindow.h
Outdated
| void init() override; | ||
| void render() override; | ||
|
|
||
| void addObj(geometry::figure *f); |
There was a problem hiding this comment.
2 варианта:
- Передавайте по значению(или rvalue ссылке), а затем делайте std::move
- Передавайте по указателю (умному)
added 2 commits
May 26, 2021 14:36
изменено: src/Voitov/Task2/CMakeLists.txt изменено: src/Voitov/Task2/cube.cpp изменено: src/Voitov/Task2/cube.hpp удалено: src/Voitov/Task2/figure.cpp изменено: src/Voitov/Task2/figure.hpp новый файл: src/Voitov/Task2/figureinformation.cpp новый файл: src/Voitov/Task2/figureinformation.h изменено: src/Voitov/Task2/main.cpp изменено: src/Voitov/Task2/uiwindow.cpp изменено: src/Voitov/Task2/uiwindow.h Исправлено название исполняемого файла c cast заменен на static_cast в src/Voitov/Task2/cube.cpp Добавлен unique_ptr
Nvoid09
force-pushed
the
feature-voitov-task-2
branch
from
78be5c8 to
d84256d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: c - cube color, b - background