Task 3 #87
Open
Task 3 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nvoid09
force-pushed
the
feature-voitov-task-3
branch
from
015f847 to
78f197f
Compare
Nvoid09
force-pushed
the
feature-voitov-task-3
branch
from
c008b01 to
293cdd0
Compare
sadads1337
approved these changes
May 27, 2021
| this->center_ = center; | ||
| //initialize block | ||
| { | ||
| gVertexes.append(VertexData({half_width, half_width, half_width}, {0.0f, 0.0f, 1.0f})); |
There was a problem hiding this comment.
Задайте индексы через initializer list, зачем делать кучу append'ов :)
|
|
||
| namespace geometry{ | ||
|
|
||
| VertexData::VertexData(QVector3D position, QVector3D normal){ |
| namespace geometry { | ||
|
|
||
| QVector<VertexData> FigureInformation::getVertexes() const noexcept{ | ||
| return this->gVertexes; |
There was a problem hiding this comment.
Каждый раз возвращаете копию объекта (это медленно), возвращайте ссылку. И для функций ниже
| window.setFormat(format); | ||
| window.resize(640, 480); | ||
|
|
||
| QVector<geometry::Cube*> cube; |
|
|
||
| void UIWindow::addObj(geometry::figure * const f) | ||
| { | ||
| //std::unique_ptr<geometry::figure> tmp = std::make_unique<geometry::figure>(f); |
There was a problem hiding this comment.
Давайте убирать закомментированный код
| GLfloat ambientStrength_ = 1.0; | ||
|
|
||
| QVector<geometry::figure*> figures; | ||
| //QVector<std::unique_ptr<geometry::figure>> figures; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: c - cube color, b - background