Refactor: use balances RTK query #4770
Conversation
Branch preview✅ Deploy successful! Storybook: |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 77.46% (-0.01% 🔻) |
13862/17895 |
| 🔴 | Branches | 56.88% (+0.06% 🔼) |
3511/6173 |
| 🟡 | Functions | 62.78% (-0.03% 🔻) |
2085/3321 |
| 🟡 | Lines | 78.9% (+0% 🔼) |
12508/15852 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / balancesSlice.ts |
61.54% (-15.38% 🔻) |
100% | 0% | 87.5% |
| 🟢 | ... / spendingLimit.ts |
84.85% | 73.33% (-3.59% 🔻) |
100% | 86.21% |
| 🟢 | ... / notification-mapper.ts |
97.5% | 82.61% (-3.11% 🔻) |
100% | 97.37% |
| 🟢 | ... / index.tsx |
100% | 70% (-2.22% 🔻) |
100% | 100% |
| 🟢 | ... / index.tsx |
93.75% (-6.25% 🔻) |
75% (+25% 🔼) |
66.67% (-33.33% 🔻) |
100% |
| 🟡 | ... / index.tsx |
72% | 53.33% (-8.21% 🔻) |
20% | 73.91% |
| 🔴 | ... / ReviewSpendingLimitTx.tsx |
40.85% (-0.82% 🔻) |
0% | 0% | 42.65% (-0.83% 🔻) |
Test suite run success
1781 tests passing in 239 suites.
Report generated by 🧪jest coverage report action from 7ca9677
katspaugh
force-pushed
the
rtk-balances
branch
from
924aebb to
fee8fd4
Compare
katspaugh
force-pushed
the
rtk-balances
branch
from
9b305eb to
14e9293
Compare
katspaugh
force-pushed
the
rtk-balances
branch
from
14e9293 to
17c3cff
Compare
📦 Next.js Bundle Analysis for @safe-global/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.06 MB (🟡 +69.54 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Thirty-two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
509 B (🟢 -1 B) |
1.06 MB |
/address-book |
23.21 KB (🟡 +143 B) |
1.08 MB |
/apps |
35.97 KB (🟡 +2.25 KB) |
1.09 MB |
/apps/custom |
34.03 KB (🟡 +2.25 KB) |
1.09 MB |
/apps/open |
55.56 KB (🟡 +1.95 KB) |
1.11 MB |
/balances |
29.83 KB (🟡 +128 B) |
1.09 MB |
/balances/nfts |
9.52 KB (🟢 -23 B) |
1.07 MB |
/bridge |
2.55 KB (🟢 -5 B) |
1.06 MB |
/cookie |
8.77 KB (🟡 +1 B) |
1.07 MB |
/home |
61.55 KB (🟡 +2.29 KB) |
1.12 MB |
/licenses |
2.46 KB (🟢 -1 B) |
1.06 MB |
/new-safe/advanced-create |
26.38 KB (🟢 -75 B) |
1.08 MB |
/new-safe/create |
25.52 KB (🟢 -67 B) |
1.08 MB |
/privacy |
14.57 KB (🟡 +2 B) |
1.07 MB |
/settings/appearance |
2.25 KB (🟡 +1 B) |
1.06 MB |
/settings/cookies |
1.87 KB (🟡 +1 B) |
1.06 MB |
/settings/modules |
4.06 KB (🟡 +3 B) |
1.06 MB |
/settings/notifications |
6.33 KB (🟢 -14.98 KB) |
1.06 MB |
/settings/safe-apps |
20.35 KB (🟡 +2.08 KB) |
1.08 MB |
/settings/security |
2.34 KB (🟡 +2 B) |
1.06 MB |
/settings/setup |
30.97 KB (🟡 +246 B) |
1.09 MB |
/share/safe-app |
7.55 KB (🟢 -8 B) |
1.06 MB |
/stake |
617 B (🟢 -2 B) |
1.06 MB |
/swap |
763 B (🟡 +3 B) |
1.06 MB |
/terms |
12.93 KB (🟡 +1 B) |
1.07 MB |
/transactions |
99.45 KB (🟡 +2.88 KB) |
1.15 MB |
/transactions/history |
99.41 KB (🟡 +2.88 KB) |
1.15 MB |
/transactions/messages |
60.25 KB (🟡 +1.95 KB) |
1.12 MB |
/transactions/msg |
56.5 KB (🟡 +1.95 KB) |
1.11 MB |
/transactions/queue |
49.36 KB (🟡 +1.96 KB) |
1.11 MB |
/transactions/tx |
48.71 KB (🟡 +1.95 KB) |
1.1 MB |
/welcome/accounts |
408 B (🟡 +1 B) |
1.06 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
katspaugh
force-pushed
the
rtk-balances
branch
from
6277a7b to
8a2d310
Compare
katspaugh
force-pushed
the
rtk-balances
branch
from
8a2d310 to
1f8a90f
Compare
katspaugh
force-pushed
the
rtk-balances
branch
from
63dd32e to
f745d18
Compare
katspaugh
force-pushed
the
rtk-balances
branch
from
f745d18 to
7305578
Compare
| trusted: isTrustedTokenList, | ||
| }, | ||
| { | ||
| skip: !isReady, |
There was a problem hiding this comment.
We also need to skip / prevent this request in case it is a counterfactual safe otherwise we are getting a 404 and an unhandled error
|
|
||
| return useMemo( | ||
| () => ({ | ||
| balances: data || cfData || { items: [], fiatTotal: '' }, |
There was a problem hiding this comment.
nit: I would extract the object fallback into a defaultBalances or emptyBalances variable
katspaugh
force-pushed
the
rtk-balances
branch
from
2647460 to
7ca9677
Compare
What it solves
pollingIntervalquery option