Using a new functions in libbraiding in zariski_vankampen #39301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit b481917; changes) is ready! 🎉 |
tscrim
added
t: enhancement
s: positive review
c: packages: optional
and removed
s: needs review
labels
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
…kampen <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The file `zariski_vankampen` used some `libbraiding` functions in order to compute the relations of the group obtained applying Zariski-van Kampen method. The use of the `super_summit_set` allowed to end computations which did not finish with a straightforward approach. But, when one works with large braid groups, the mehtod `super_summit_set` can be very long, and running along its output is even longer. The new `libbraiding` version includes the method `super_summit_set_element` which simplifies and fasten the computations. The main changes are in method `conjugate_positive_form` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39301 Reported by: Enrique Manuel Artal Bartolo Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
…kampen
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The file `zariski_vankampen` used some `libbraiding` functions in order
to compute the relations of the group obtained applying Zariski-van
Kampen method. The use of the `super_summit_set` allowed to end
computations which did not finish with a straightforward approach. But,
when one works with large braid groups, the mehtod `super_summit_set`
can be very long, and running along its output is even longer. The new
`libbraiding` version includes the method `super_summit_set_element`
which simplifies and fasten the computations. The main changes are in
method `conjugate_positive_form`
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39301
Reported by: Enrique Manuel Artal Bartolo
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
…kampen
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The file `zariski_vankampen` used some `libbraiding` functions in order
to compute the relations of the group obtained applying Zariski-van
Kampen method. The use of the `super_summit_set` allowed to end
computations which did not finish with a straightforward approach. But,
when one works with large braid groups, the mehtod `super_summit_set`
can be very long, and running along its output is even longer. The new
`libbraiding` version includes the method `super_summit_set_element`
which simplifies and fasten the computations. The main changes are in
method `conjugate_positive_form`
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39301
Reported by: Enrique Manuel Artal Bartolo
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 17, 2025
…kampen
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The file `zariski_vankampen` used some `libbraiding` functions in order
to compute the relations of the group obtained applying Zariski-van
Kampen method. The use of the `super_summit_set` allowed to end
computations which did not finish with a straightforward approach. But,
when one works with large braid groups, the mehtod `super_summit_set`
can be very long, and running along its output is even longer. The new
`libbraiding` version includes the method `super_summit_set_element`
which simplifies and fasten the computations. The main changes are in
method `conjugate_positive_form`
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39301
Reported by: Enrique Manuel Artal Bartolo
Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
zariski_vankampenused somelibbraidingfunctions in order to compute the relations of the group obtained applying Zariski-van Kampen method. The use of thesuper_summit_setallowed to end computations which did not finish with a straightforward approach. But, when one works with large braid groups, the mehtodsuper_summit_setcan be very long, and running along its output is even longer. The newlibbraidingversion includes the methodsuper_summit_set_elementwhich simplifies and fasten the computations. The main changes are in methodconjugate_positive_form📝 Checklist
⌛ Dependencies