-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bijectionist/improve init #39313
base: develop
Are you sure you want to change the base?
Bijectionist/improve init #39313
Conversation
Documentation preview for this PR (built with commit 2a65040; changes) is ready! 🎉 |
@@ -2144,6 +2144,17 @@ def _preprocess_intertwining_relations(self): | |||
sage: bij._P | |||
{{'a'}, {'b'}, {'c'}, {'d'}} | |||
|
|||
However, adding that `'a'` and `'c'` are in the same block, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also in #39310
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I branched from the other PR.
@@ -2152,6 +2163,11 @@ def _preprocess_intertwining_relations(self): | |||
sage: bij._preprocess_intertwining_relations() | |||
sage: bij._P | |||
{{[1, 2, 3]}, {[1, 3, 2]}, {[2, 1, 3]}, {[2, 3, 1]}, {[3, 1, 2]}, {[3, 2, 1]}} | |||
|
|||
Thus, in this case we do not detect the constant blocks:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also in #39310
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fix #39307
Since the package is currently probably a bit under-used, this should be checked thoroughly.