Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bijectionist/improve init #39313

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mantepse
Copy link
Collaborator

Fix #39307

Since the package is currently probably a bit under-used, this should be checked thoroughly.

Copy link

Documentation preview for this PR (built with commit 2a65040; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@@ -2144,6 +2144,17 @@ def _preprocess_intertwining_relations(self):
sage: bij._P
{{'a'}, {'b'}, {'c'}, {'d'}}

However, adding that `'a'` and `'c'` are in the same block,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also in #39310

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I branched from the other PR.

@@ -2152,6 +2163,11 @@ def _preprocess_intertwining_relations(self):
sage: bij._preprocess_intertwining_relations()
sage: bij._P
{{[1, 2, 3]}, {[1, 3, 2]}, {[2, 1, 3]}, {[2, 3, 1]}, {[3, 1, 2]}, {[3, 2, 1]}}

Thus, in this case we do not detect the constant blocks::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also in #39310

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bijectionist does avoidable work
2 participants