Add flatter support #40274
Open
Add flatter support #40274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit dc5a22f; changes) is ready! 🎉 |
dimpase
reviewed
Jun 25, 2025
| @@ -3097,6 +3101,16 @@ cdef class Matrix_integer_dense(Matrix_dense): | |||
| [0 0 0] | |||
| [0 0 0] | |||
|
|
|||
| When ``algorithm='flatter'``, some matrices are not supported depends | |||
There was a problem hiding this comment.
the sentence is broken. When is a Germanism, too. You want something like
The ``algorithm='flatter'`` might not support matrices supported by other algorithms.
dimpase
reviewed
Jun 25, 2025
| @@ -3024,6 +3024,10 @@ cdef class Matrix_integer_dense(Matrix_dense): | |||
|
|
|||
| - ``'pari'`` -- pari's qflll | |||
|
|
|||
| - ``'flatter'`` -- external executable ``flatter``, requires manual install (see caveats below). | |||
| Note that sufficiently new version of ``pari`` also supports FLATTER algorithm, see | |||
There was a problem hiding this comment.
please provide Pari version info where this appeared. Also, do you know if this already is available from cypari2 ?
dimpase
reviewed
Jun 25, 2025
| if fp is not None or early_red or use_givens or transformation or eta is not None or use_siegel: | ||
| raise TypeError("flatter does not support fp, early_red, use_givens, transformation, eta or use_siegel") | ||
| if kwds: | ||
| raise TypeError("flatter does not support additional keywords") |
There was a problem hiding this comment.
would it be more consistent to just ignore kwds here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports calling external
flatterexecutable forLLLalgorithm. (If the user wants to use this it is necessary to install from source from https://github.com/keeganryan/flatter)📝 Checklist
⌛ Dependencies