Skip to content

Fix tests with scipy 1.16 #40285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

antonio-rojas
Copy link
Contributor

Make tests pass with scipy 1.16:

  • Drop deprecated iprint parameter for l-bfgs-b algorithm.
  • Adapt to output changes with new COBYLA implementation.

In particular, the tests in https://github.com/sagemath/sage/blob/10.7.beta6/src/sage/numerical/optimize.py#L522-L525 give a completely different answer, which is as meaningless as the previous one since the function does not have a minimum. We mark them as random, since their only purpose is to test that it doesn't throw an error.

Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and it should be backward compatible.

Copy link

Documentation preview for this PR (built with commit 094ca44; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants