Fix loading symbolic expressions containing symbolic functions #40294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 0d915da; changes) is ready! 🎉 |
user202729
reviewed
Jun 23, 2025
| sage: t = tmp_filename(ext='.sobj') | ||
| sage: save(u, t) | ||
| sage: load(t) | ||
| u(x, y) |
There was a problem hiding this comment.
does testing with dumps/loads work? Avoid the temp file
user202729
reviewed
Jun 23, 2025
| @@ -817,7 +817,9 @@ cdef unsigned py_get_serial_for_new_sfunction(stdstring &s, | |||
| create one and set up the function tables properly. | |||
| """ | |||
| from sage.symbolic.function_factory import function_factory | |||
| cdef Function fn = function_factory(s.c_str(), nargs) | |||
| cdef const char* c_name = s.c_str() | |||
| py_name = c_name.decode('UTF-8') | |||
There was a problem hiding this comment.
either add comment to explain where the corresponding encode() is (to justify using UTF-8 here), or add a test with some Unicode characters in function name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies