-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use NATS #8118
Open
williamstein
wants to merge
387
commits into
master
Choose a base branch
from
nats
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
use NATS #8118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2025
- building a robust foundation :-)
…cts and accounts can only read)
…than the very restricted subject segment names
- we use the sha1 hash of the key in nats and keep track of original key as part of the value - pros and cons: - pro: a lot of probably bugs and subtle ugly code with dangerous conventions doesn't have to get written, and it would basically do the same thing - con: harder to observer what is going on (e.g., impossible with nats cli)... but we can certainly build tooling
- *not* loving this code, but at least less code duplication
…ccount only dstream via more auth rules - we don't have an application yet for account only auth streams...
- it passes tests but doesn't seem to work for patches yet...
…eletes properly yet" (this is a bad approach) This reverts commit b5b1f25.
…ke JWT also a function of the api key
- maybe i'm the first person ever to use auth callout from typescript. - this is enough to be able to do figure out anything :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely some proofs of concept and likely will never be merged.This works and is serious.