Conat -- replacing NATS with socketio + sqlite3 + valkey + nodejs #8346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamstein
force-pushed
the
conat
branch
2 times, most recently
from
d9de6db to
6ad5f21
Compare
williamstein
force-pushed
the
conat
branch
4 times, most recently
from
7620829 to
9aa8524
Compare
…once also listen for 'closed' - subscription sync algorithm should be rock solid (modulo bugs in implementation) - test suite massively broken now.
- this fixes some situations where init() was being called more than once, resulting in leaks - there are still leaks with jupyter, which I haven't fixed yet
- closing a project's actions closed all the files, which checked if they were deleted during the save, which opened the project actions - this led to a major leak - from now on everywhere in cocalc, the close method is like for sockets -- it closes the thing synchronously and brutally. To close gently, instead implement and "end" method.
…roject" - naming it project makes it look like it should contain the project the process is running in
…ving two very different ways is too confusing
… *project* tab - this wasn't happening at all; resources were only freed when a file was closed explicitly, not a whole project tab
… when path is relative)
- it can be faster/smaller than json/mesgpack, but more importantly it also seems to have very good support for Set/Map/Error/undefined, which is convenient.
…ter, and (2) it is NOT compatible with the msgpack implementations for other languages like python and we want to have a conat python client, and (3) support for Set, etc., isn't important and might tie us in too much Revert "add support for mesgpackr and make it the default" This reverts commit 86bd517.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.