Remove unnecessary awaits #5296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78f482a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
szczecha
previously approved these changes
Dec 2, 2024
poulch
previously approved these changes
Dec 3, 2024
michalina-graczyk
dismissed stale reviews from poulch and szczecha
via
263699e
szczecha
approved these changes
Dec 19, 2024
andrzejewsky
requested changes
Dec 27, 2024
| const selectedLinkType = await this.menuLinkType.inputValue(); | ||
|
|
||
| if (selectedLinkType !== linkType) { | ||
| throw new Error(`Expected link type "${linkType}" but found "${selectedLinkType}"`); |
There was a problem hiding this comment.
this should be an assert, not exception raising, this will break the test execution by unhandled error
| await this.menuLinkOptions.filter({ hasText: option }).click({ force: true }); | ||
| await this.waitForDOMToFullyLoad(); | ||
|
|
||
| // Ensure the link type option is visible and select it |
There was a problem hiding this comment.
LLM models generate usually tons on comments, explaining what they do - it's useful when composing the final solution, but usually redundant when used in the destined codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description