@W-17649725 Removing nonFlowOnly from the context of TIMENOW and TIMEVALUE #150
Conversation
|
Thanks for the contribution! It looks like @akshay-krishnan-flow is an internal user so signing the CLA is not required. However, we need to confirm this. |
|
The FTest testcase which involves a formula syntax check of the TIMENOW() and TIMEVALUE() operations introduced as part of this PR https://gitcore.soma.salesforce.com/core-2206/core-public/pull/75721 is failing right now because the nonFlowOnly property is set to true for both those formula functions. Upon removing them and rerunning the test on local, they are successful |
|
@akshay-krishnan-flow "nonFlowOnly" is owned & used by feature teams, your changes looks good from the formula engine aspect. Please consult with the "IoT Haleakala" team as they also use "nonFlowOnly". |
@akshay-krishnan-flow, can you drop a message here confirming you are an internal developer? (standard procedure). I manually added "cla:signed" label here. |
@bairenlong-sfdc I confirm that I am an internal developer. |
akshay-krishnan-flow
changed the title
|
@jonathonmar I was waiting for confirmation from the IOT team for "nonFlowOnly" related changes. @akshay-krishnan-flow I will deploy your changes to core but you still need to confirm your changes with IOT team. |
@bairenlong-sfdc I got the confirmation from the IoT team. I just updated our discussion thread on Slack with the link to the confirmation. |
@W-17649725 This PR contains the changes done on the Formula Engine side to add Time data type support to the Formula Builder of Flow Builder. FunctionTimeValue and FunctionTimeNow are two formula functions which perform Time related operations. These two functions currently have the nonFlowOnly property in their context set to true and the removal of this property is essential for Flow Builder to be able consume these two formulas.