Add NODE_VERSION_OVERRIDE
everywhere
#1265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We had a Repo level variable called
TARBALL_NODE_VERSION
to manually set the Node version. However, this was only used for setting the Node version in the Tarballs and Docker images. We recently had issues when moving from Node 18 to Node 20. Some tests were failing because they were running with Node 20 despiteTARBALL_NODE_VERSION
being set.This PR renames the variable to
NODE_VERSION_OVERRIDE
and uses it all over: unitTests, NUTs, verify scripts, JIT smoke tests, etc. This provides several benefits:npm
being usedcurrent
of Nodesf@v1
)There are a few other changes include in this PR:
nick-fields/retry
Retry wrapper and determine node versions github-workflows#79@W-14338799@