Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NODE_VERSION_OVERRIDE everywhere #1265

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

iowillhoit
Copy link
Contributor

@iowillhoit iowillhoit commented Nov 1, 2023

IMPORTANT
Don't merge before we replace @ew/retry-wrapper with @main
Also merge this one first: salesforcecli/github-workflows#79

What does this PR do?

We had a Repo level variable called TARBALL_NODE_VERSION to manually set the Node version. However, this was only used for setting the Node version in the Tarballs and Docker images. We recently had issues when moving from Node 18 to Node 20. Some tests were failing because they were running with Node 20 despite TARBALL_NODE_VERSION being set.

This PR renames the variable to NODE_VERSION_OVERRIDE and uses it all over: unitTests, NUTs, verify scripts, JIT smoke tests, etc. This provides several benefits:

  • Increased confidence since unit, smoke, and NUTs are executing with the same version shipped with the CLI
    • This also applies to the version of npm being used
  • Allow us to create a pre-release prior to an LTS transition to make sure everything will work ok
    • If we wanted to, we could create a weekly "next" release that uses the current of Node
  • Allows us to release with a previous Node version (if we had to patch sf@v1)
    • Would need to update workflows in that branch first

There are a few other changes include in this PR:

@W-14338799@

shetzel
shetzel previously approved these changes Nov 3, 2023
@iowillhoit iowillhoit merged commit 84371c1 into main Nov 3, 2023
31 checks passed
@iowillhoit iowillhoit deleted the ew/node-version-override branch November 3, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants