Remove deprecated inputs #1823
Merged
Remove deprecated inputs #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iowillhoit
commented
Aug 2, 2024
| @@ -101,5 +101,3 @@ jobs: | |||
| with: | |||
| retry_wait_seconds: 1 | |||
| command: ${{ inputs.command }} | |||
| # TODO: any reason we dont retry on errors AND timeouts? (any) | |||
| retry_on: error | |||
There was a problem hiding this comment.
Removing this will default to any error. We had an example this morning where a NUT did not re-run because of a timeout https://github.com/salesforcecli/cli/actions/runs/10209026168/job/28246609426
iowillhoit
commented
Aug 2, 2024
| @@ -20,7 +20,6 @@ jobs: | |||
| make-pr-for-nightly: | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.SVC_CLI_BOT_GITHUB_TOKEN }} | |||
| SF_HIDE_RELEASE_NOTES: true | |||
There was a problem hiding this comment.
This is a global org env now
cristiand391
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes unused inputs. Now that we only have
sfwe do not need to pass in the cliMoves inputs and steps to
envMerge after salesforcecli/github-workflows#124
@W-16223935@