Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Representation decorator needs a base_type #918

Open
cgreenberg opened this issue Jan 11, 2016 · 1 comment
Open

Representation decorator needs a base_type #918

cgreenberg opened this issue Jan 11, 2016 · 1 comment
Labels

Comments

@cgreenberg
Copy link
Contributor

Currently the base type is assumed to be IMP.atom.BALLS, but that shouldn't be required. Maybe we want to represent a fragment with only density.

Also, any objections if I just replace everywhere IMP.atom.BALLS to IMP.atom.BEADS ?

@benmwebb
Copy link
Member

Sounds reasonable, but you can't just do a wholesale search and replace - we'd need to keep BALLS as a (deprecated) synonym to avoid breaking any existing code that uses it (probably not much).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants