Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update examples - chakra-ui added #403

Merged
merged 2 commits into from
Sep 21, 2023
Merged

update examples - chakra-ui added #403

merged 2 commits into from
Sep 21, 2023

Conversation

KtanPatel
Copy link
Contributor

Chakra Ui - example

light_theme

dark_theme

@KtanPatel
Copy link
Contributor Author

Hey @saltyshiomix,

Please review it or assign someone else who can review and merge this chakra-ui example/template. I loved to contributes and use this combo (nextron with chakra ui) for my next experiment projects .

Thanks.

saltyshiomix
saltyshiomix approved these changes Sep 20, 2023
View reviewed changes
Copy link
Owner

@saltyshiomix saltyshiomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @KtanPatel !

It works perfectly, and big thanks to your efforts and the clean code 🥇

I just approved, but if you have time please update next.config.js in the review comment 🙇

examples/with-chakra-ui/renderer/next.config.js Outdated Show resolved Hide resolved
@saltyshiomix
Copy link
Owner

Dark mode is so much pretty!

@saltyshiomix
Copy link
Owner

@KtanPatel

Sorry, please kindly add trailingSlash: true in next.config.js?

Go to next page is not working when production mode, so we have to set this config 🙇

@KtanPatel
Copy link
Contributor Author

@KtanPatel

Sorry, please kindly add trailingSlash: true in next.config.js?

Go to next page is not working when production mode, so we have to set this config 🙇

@saltyshiomix

next.config.js is updated as per your suggestions.

Thank you! 😊

@saltyshiomix saltyshiomix merged commit b5edf46 into saltyshiomix:main Sep 21, 2023
2 checks passed
@saltyshiomix
Copy link
Owner

@KtanPatel
I proudly merged it into main 💯
Thanks!

@saltyshiomix saltyshiomix mentioned this pull request Sep 21, 2023
Open
saltyshiomix added a commit that referenced this pull request Sep 21, 2023
@saltyshiomix
fix(examples): Update next.config.js for production build #403
7cd277e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saltyshiomix saltyshiomix saltyshiomix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KtanPatel @saltyshiomix