Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-infra: Fix boolean true args in URL getting ignored [Storybook] #1096

Merged
merged 1 commit into from
Mar 6, 2024
Merged

plasma-infra: Fix boolean true args in URL getting ignored [Storybook] #1096

merged 1 commit into from
Mar 6, 2024

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Mar 5, 2024 •
edited by Salute-Eva
Loading

Storybook

  • обновили версию storybook чтобы исправить - boolean true args in URL getting ignored

https://github.com/storybookjs/storybook/releases/tag/v7.6.14

Было: Button доступен когда prop disabled === true

Screenshot 2024-03-05 at 19 43 03

Стало: Button недоступен когда prop disabled === true

Screenshot 2024-03-05 at 19 25 07

What/why changed

Обновили версию storybook, чтобы исправить проблемы с инверсией/игнорированием boolean args в URL

storybookjs/storybook#25950

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc added plasma-infra changelog-skip Exclude pull request changes from changelog labels Mar 5, 2024
@Yakutoc Yakutoc self-assigned this Mar 5, 2024
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1096/

@Yakutoc Yakutoc force-pushed the ci-fix-storybook-boolean-url branch from 9b6036e to f311301 Compare March 5, 2024 12:52
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1096/

@Yakutoc Yakutoc requested a review from IgorYar March 5, 2024 12:55
@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1096/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1096/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1096/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1096/ui-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1096/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1096/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1096/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1096/caldera-online-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1096/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc marked this pull request as ready for review March 5, 2024 13:33
@Yakutoc Yakutoc removed the request for review from Yeti-or March 6, 2024 08:51
@Yakutoc
chore(storybook): bump storybook to "@latest"
5e0ada3 
fix boolean true args in URL getting ignored
@Yakutoc Yakutoc force-pushed the ci-fix-storybook-boolean-url branch from f311301 to 5e0ada3 Compare March 6, 2024 10:55
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1096/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1096/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1096/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1096/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1096/ui-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1096/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1096/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1096/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1096/caldera-online-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1096/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc merged commit 6789781 into dev Mar 6, 2024
24 of 25 checks passed
@Yakutoc Yakutoc deleted the ci-fix-storybook-boolean-url branch March 6, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayman233 kayman233 kayman233 approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@IgorYar IgorYar IgorYar approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

Assignees

@Yakutoc Yakutoc

Labels
changelog-skip Exclude pull request changes from changelog plasma-infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yakutoc @Salute-Eva @Yeti-or @IgorYar @neretin-trike @kayman233