-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esm first #1492
Draft
ryoppippi
wants to merge
14
commits into
samchon:master
Choose a base branch
from
ryoppippi:feature/esm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
esm first #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tsconfig.cjs.json to support dual module mode (ESM/CommonJS) builds, configuring CommonJS output to lib-cjs/ directory.
commit: |
OK so I still need bundler |
I was facing a issue for bundling, i think it's better to work on |
I just add |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
d97fdaf
to
44124c0
Compare
Replace rollup.config.js with tsconfig.cjs.json in the build workflow path triggers to align with ESM migration changes.
44124c0
to
413b7ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Draft PR. wait until completion
This pull request includes several changes aimed at improving module handling, simplifying the deployment process, and updating configurations. The most important changes include modifying import statements to use ES module syntax, restructuring the
deploy
scripts, and updating thepackage.json
file to reflect these changes.Module Handling Improvements:
deploy/bun.ts
,deploy/index.ts
,deploy/internal/DeployRunner.ts
, anddeploy/internal/ReplicaPublisher.ts
[1] [2] [3] [4].__dirname
withimport.meta.dirname
for module path resolution indeploy/internal/DeployRunner.ts
anddeploy/internal/ReplicaPublisher.ts
[1] [2] [3] [4] [5] [6] [7] [8].Deployment Script Simplification:
deploy/bun.ts
anddeploy/index.ts
by removing themain
function and directly executing the deployment logic [1] [2] [3] [4] [5].Configuration Updates:
package.json
file to add the"type": "module"
field and restructured the build and deploy scripts to use ES modules [1] [2] [3].tsconfig.cjs.json
file to support CommonJS module compilation.Workflow Adjustments:
.github/workflows/build.yml
file to replacerollup.config.js
withtsconfig.cjs.json
in the workflow triggers.Removal of Rollup Configuration:
rollup.config.js
file as it is no longer needed with the new build process.