Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm first #1492

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

esm first #1492

wants to merge 14 commits into from

Conversation

ryoppippi
Copy link
Contributor

@ryoppippi ryoppippi commented Feb 5, 2025

This is a Draft PR. wait until completion

This pull request includes several changes aimed at improving module handling, simplifying the deployment process, and updating configurations. The most important changes include modifying import statements to use ES module syntax, restructuring the deploy scripts, and updating the package.json file to reflect these changes.

Module Handling Improvements:

  • Changed import statements to use ES module syntax in deploy/bun.ts, deploy/index.ts, deploy/internal/DeployRunner.ts, and deploy/internal/ReplicaPublisher.ts [1] [2] [3] [4].
  • Replaced __dirname with import.meta.dirname for module path resolution in deploy/internal/DeployRunner.ts and deploy/internal/ReplicaPublisher.ts [1] [2] [3] [4] [5] [6] [7] [8].

Deployment Script Simplification:

  • Simplified the deployment scripts in deploy/bun.ts and deploy/index.ts by removing the main function and directly executing the deployment logic [1] [2] [3] [4] [5].

Configuration Updates:

  • Updated the package.json file to add the "type": "module" field and restructured the build and deploy scripts to use ES modules [1] [2] [3].
  • Added a new tsconfig.cjs.json file to support CommonJS module compilation.

Workflow Adjustments:

  • Modified the .github/workflows/build.yml file to replace rollup.config.js with tsconfig.cjs.json in the workflow triggers.

Removal of Rollup Configuration:

  • Removed the rollup.config.js file as it is no longer needed with the new build process.

Add tsconfig.cjs.json to support dual module mode (ESM/CommonJS) builds,
configuring CommonJS output to lib-cjs/ directory.
Copy link

pkg-pr-new bot commented Feb 5, 2025

Open in Stackblitz

npm i https://pkg.pr.new/typia@1492

commit: 413b7ab

Copy link

socket-security bot commented Feb 5, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 176 kB pieroxy
npm/[email protected] environment, network 0 99 MB vscode-bot
npm/[email protected] Transitive: filesystem +20 872 kB iamvishnusankar
npm/[email protected] Transitive: environment, filesystem, shell +30 1.17 GB rauchg, timneutkens, vercel-release-bot
npm/[email protected] Transitive: environment, eval +22 6.13 MB quietshu
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +384 239 MB quietshu
npm/[email protected] environment +2 40.8 kB jinder
npm/[email protected] None 0 15.3 kB cwmma
npm/[email protected] environment +3 4.63 MB react-bot
npm/[email protected] environment +2 339 kB react-bot
npm/[email protected] Transitive: network +1 669 kB samchon
npm/[email protected] None +6 499 kB blakeembrey, jbrantly, johnnyreilly
npm/[email protected] None 0 2.58 MB samchon
npm/[email protected] filesystem 0 14.7 kB julianwowra
npm/[email protected] None +3 2 MB typedoc-bot
npm/[email protected] Transitive: filesystem, shell +1 4.02 MB samchon
npm/[email protected] filesystem Transitive: environment +3 4.43 MB gajus

🚮 Removed packages: npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@ryoppippi
Copy link
Contributor Author

OK so I still need bundler

@ryoppippi
Copy link
Contributor Author

I was facing a issue for bundling, i think it's better to work on @samchon/openapi first

@ryoppippi
Copy link
Contributor Author

I just add .js extensions to @samchon/openapi

@ryoppippi ryoppippi marked this pull request as draft February 5, 2025 22:54
Copy link

socket-security bot commented Feb 5, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant