-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing outdated references to Elasticsearch #26
base: main
Are you sure you want to change the base?
Conversation
…rch is installed with FIREWHEEL.
This looks good to me. I think I missed the fact that in #14 we actually got rid of the My thinking is just that I will often try to call |
It looks like based on the latest packaging guide: https://packaging.python.org/en/latest/discussions/versioning/#accessing-version-information-at-runtime it seems like it is not required, but many projects choose to do so. Given that there is minimal overhead to maintain. I'll add that back but use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Sorry it took so long, I hadn't checked my pending reviews lately.
This PR updates the documentation to fix an outdated comment that Elasticsearch is installed with FIREWHEEL. Additionally, we fix a bug introduced by #14 which neglected to update the version for the Sphinx documentation.