Provide CI testing support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelliot
reviewed
Nov 15, 2024
mitchnegus
force-pushed
the
tests
branch
3 times, most recently
from
5339623 to
0565cc7
Compare
mitchnegus
force-pushed
the
tests
branch
2 times, most recently
from
c210aa1 to
56e1493
Compare
|
|
mitchnegus
force-pushed
the
tests
branch
2 times, most recently
from
9aba855 to
94b170f
Compare
mitchnegus
commented
Jan 23, 2025
mitchnegus
commented
Jan 23, 2025
mitchnegus
commented
Jan 23, 2025
sdelliot
reviewed
Jan 23, 2025
mitchnegus
force-pushed
the
tests
branch
3 times, most recently
from
7bd67a0 to
424d255
Compare
Add a dependency group for MC repos that may be installed along with the FIREWHEEL package. This commit also excludes tests relying on those MC repos from the GitHub testing workflow.
This drops coverage to 60% so that the unit tests pass. This coverage is lower than previous pipelines, likely because this coverage level only reflects unit tests (and not functional tests) and because the current pipeline is excluding both long-running tests and tests that depend on other MCs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a starting point for converting our GitLab CI testing infrastructure to the GitHub Actions workflow.
Workflow Upgrades
To avoid duplication in the workflow scripts, I've created a new set of composite actions to install minimega, discovery, FIREWHEEL, and tox. We should hopefully be able to use these composite actions to dramatically simplify some of the CI scripts we had before. I've also upgraded the versions of referenced reusable versions where possible.
Test Enhancements
The unit tests have been upgraded to provide increased utility and work better through the FIREWHEEL interface:
firewheel test unithelper now returns the appropriate exit code returned by pytest, which was previously unintentionally suppressed.-moption to select marked tests for inclusion/exclusion rather than adding custom options.Bug Fixes
This PR also fixes a few bugs in the current implementation:
test_cli_completion.pyscript).shlexfor proper parsing.