Provide CI testing support #8
Conversation
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: |
There was a problem hiding this comment.
It seems reasonable to also require installing Python here. Are there compelling reasons why choosing a standard version (3.11) and using that for all tox jobs wouldn't work?
There was a problem hiding this comment.
The reason I had not included that one was because I hadn't put thought into how the matrixing versions (in lint) and full inclusion of all versions (in the tests) should be reconciled.
When we run tox -e py39,py310,... it runs an individual tox job for tests for each. That means that the runner has to have all those versions of Python installed to start with, because tox will look for each Python as it runs each job. But for linting, our tox -e lint job will just use whichever Python is the default in our virtual environment (I think).
The setup-python action seems to allow you to specify the default Python version as the last version identified among multiple selected. I'd think if nothing else we might want to control which version is used for linting (e.g., 3.11 like you suggested).
Also, another concern that popped into my head might be that there could be a performance penalty for installing all versions of Python for the linting job. From what I can see on the pipelines right now, it's less than 1 second for just one version at a time and closer to 9 seconds to install all 6 (Python 3.8 through 3.13). That's not huge for a CI pipeline—especially if it's running concurrent with tests which will almost always take far longer—so I'm inclined to think it's not a big deal.
mitchnegus
force-pushed
the
tests
branch
3 times, most recently
from
5339623 to
0565cc7
Compare
mitchnegus
force-pushed
the
tests
branch
2 times, most recently
from
c210aa1 to
56e1493
Compare
This provides a starting point for converting our GitLab CI testing infrastructure to the GitHub Actions workflow.
In the process, this fixes a testing error identified by testing the FIREWHEEL deployment in an fresh installation (a hardcoded path in the
test_cli_completion.pyscript.To avoid duplication in the workflow scripts, I've created a new composite action to install the tox dependencies. We should hopefully be able to use these composite actions to dramatically simplify some of the CI scripts we had before.